Fix crash that could occur if closing the usercard quickly after blocking #4711
Conversation
…cking or unblocking Specifically, this adds a caller to the network request, which makes the success or failure callback not fire. This has the unintended consequence of the block list not reloading if the usercard is closed
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -121,11 +121,12 @@ void TwitchAccount::loadBlocks() | |||
| }); | |||
| } | |||
|
|
|||
| void TwitchAccount::blockUser(QString userId, std::function<void()> onSuccess, | |||
| void TwitchAccount::blockUser(QString userId, const QObject *caller, | |||
There was a problem hiding this comment.
warning: the parameter 'userId' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
| void TwitchAccount::blockUser(QString userId, const QObject *caller, | |
| void TwitchAccount::blockUser(const QString& userId, const QObject *caller, |
src/providers/twitch/TwitchAccount.hpp:74:
- void blockUser(QString userId, const QObject *caller,
+ void blockUser(const QString& userId, const QObject *caller,| @@ -121,11 +121,12 @@ | |||
| }); | |||
| } | |||
|
|
|||
| void TwitchAccount::blockUser(QString userId, std::function<void()> onSuccess, | |||
| void TwitchAccount::blockUser(QString userId, const QObject *caller, | |||
| std::function<void()> onSuccess, | |||
There was a problem hiding this comment.
warning: the parameter 'onSuccess' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
| std::function<void()> onSuccess, | |
| const std::function<void()>& onSuccess, |
src/providers/twitch/TwitchAccount.hpp:75:
- std::function<void()> onSuccess,
+ const std::function<void()>& onSuccess,| @@ -141,11 +142,12 @@ | |||
| std::move(onFailure)); | |||
| } | |||
|
|
|||
| void TwitchAccount::unblockUser(QString userId, std::function<void()> onSuccess, | |||
| void TwitchAccount::unblockUser(QString userId, const QObject *caller, | |||
There was a problem hiding this comment.
warning: the parameter 'userId' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
| void TwitchAccount::unblockUser(QString userId, const QObject *caller, | |
| void TwitchAccount::unblockUser(const QString& userId, const QObject *caller, |
src/providers/twitch/TwitchAccount.hpp:77:
- void unblockUser(QString userId, const QObject *caller,
+ void unblockUser(const QString& userId, const QObject *caller,| @@ -141,11 +142,12 @@ | |||
| std::move(onFailure)); | |||
| } | |||
|
|
|||
| void TwitchAccount::unblockUser(QString userId, std::function<void()> onSuccess, | |||
| void TwitchAccount::unblockUser(QString userId, const QObject *caller, | |||
| std::function<void()> onSuccess, | |||
There was a problem hiding this comment.
warning: the parameter 'onSuccess' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
| std::function<void()> onSuccess, | |
| const std::function<void()>& onSuccess, |
src/providers/twitch/TwitchAccount.hpp:78:
- std::function<void()> onSuccess,
+ const std::function<void()>& onSuccess,
Description
-DUSE_ALTERNATE_LINKERcmake option