Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focus message input when selecting emotes in emote popup #4719

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

LoneCoder21
Copy link
Contributor

Description

When selecting emotes in emote popup menu, it doesn't automatically focus the message input. This is slightly annoying as I would like to type something immediately afterwards.

@LoneCoder21 LoneCoder21 reopened this Jul 11, 2023
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets a bit funky on tiling window managers on Linux, but it still works well.

Does anyone dislike this feature? If not, I will just merge this in next weekend

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, I'm not a emote menu user but it's not like we are taking focus from the emote menu search to implement this.

@pajlada pajlada enabled auto-merge July 29, 2023 10:28
@pajlada pajlada added this pull request to the merge queue Jul 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 29, 2023
@pajlada pajlada added this pull request to the merge queue Jul 29, 2023
Merged via the queue into Chatterino:master with commit 9cb59f7 Jul 29, 2023
15 of 16 checks passed
@pajlada
Copy link
Member

pajlada commented Jul 30, 2023

As a first-time contributor, you can now add yourself to the contributors list that's shown inside the About page in Chatterino.

If you want this, you can open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at the top for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants