Fix tooltip & popup positioning #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to ensure the tooltip & popups are created on the correct monitor
pajlada
force-pushed
the
fix/tooltip-and-popup-positioning
branch
from
980ff04
to
f9ec53f
Compare
|
Looking for testers with dual-monitor setups for the following platforms: The test steps are outlined in the PR description, hopefully should be easy enough to follow along |
|
The relevant platforms have been tested a bit, and with that I'm happy to merge this in. The biggest change this does is: Don't move the widget multiple times upon showing
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
* Fix tooltip & popup positioning This tries to ensure the tooltip & popups are created on the correct monitor * Add changelog entry * Clean up debug output * Use the full frame geometry to figure out screen bound movements * Remove the now-unused `setStayInScreenRect` function * Change the UserInfoPopup offset to be based on its width & height instead * Remove more debug output
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
* Fix tooltip & popup positioning This tries to ensure the tooltip & popups are created on the correct monitor * Add changelog entry * Clean up debug output * Use the full frame geometry to figure out screen bound movements * Remove the now-unused `setStayInScreenRect` function * Change the UserInfoPopup offset to be based on its width & height instead * Remove more debug output
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This tries to ensure the tooltip & popups are created on the correct
monitor
Test steps
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up at the same place every time
regardless of where my Chatterino or cursor is
TODO: Add proper test steps to ensure we get testing on all platforms
Tested on
Linux Wayland
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up at the same place every time
regardless of where my Chatterino or cursor is
Linux X11
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up at the same place every time
regardless of where my Chatterino or cursor is
macOS
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up at the same place every time
regardless of where my Chatterino or cursor is
Windows 100% zoom
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up at the same place every time
regardless of where my Chatterino or cursor is
Windows >100% zoom
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up on the same screen as my cursor
It shows up at the same place every time
regardless of where my Chatterino or cursor is
Fixes #4733
Fixes #4572