Fixed right-clicking mentions no longer working. #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
approved these changes
Aug 4, 2023
Mm2PL
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Felanbird
reviewed
Aug 4, 2023
| @@ -19,6 +19,7 @@ | |||
| - Minor: Stream status requests are now batched. (#4713) | |||
| - Minor: Added `/c2-theme-autoreload` command to automatically reload a custom theme. This is useful for when you're developing your own theme. (#4718) | |||
| - Minor: Show channel point redemptions without messages in usercard. (#4557) | |||
| - Minor: Allow for customizing the behavior of `Right Click`ing of usernames. (#4622, #4751) | |||
There was a problem hiding this comment.
note: this changelog was accidentally dropped in 2.4.4 but was not apart of said version, and since this PR is a followup it seems correct to move it back in this PR
pajlada
approved these changes
Aug 5, 2023
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
* fix up rightclicking mentions * changelog * Merge changelog entries other PR was merged after 2.4.4
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
* fix up rightclicking mentions * changelog * Merge changelog entries other PR was merged after 2.4.4
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4750.
Implementation caveat: this uses the mention text to check if its the person who sent the message. So if I send a message and I mention myself in it, anyone can reply to it with the mention. Seemed like a good tradeoff rather than updating all code using MessageElementFlags to see which Username is sender's name and which is mention.