Refactor recent messages API #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes internal functions for testing
pajlada
force-pushed
the
chore/refactor-recent-messages-api
branch
from
3205776
to
fcb41ed
Compare
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| using namespace recentmessages::detail; | ||
|
|
||
| void load(const QString &channelName, std::weak_ptr<Channel> channelPtr, |
There was a problem hiding this comment.
warning: the parameter 'channelPtr' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| void load(const QString &channelName, std::weak_ptr<Channel> channelPtr, | |
| void load(const QString &channelName, const std::weak_ptr<Channel>& channelPtr, |
src/providers/recentmessages/Api.hpp:31:
- void load(const QString &channelName, std::weak_ptr<Channel> channelPtr,
+ void load(const QString &channelName, const std::weak_ptr<Channel>& channelPtr,| using namespace recentmessages::detail; | ||
|
|
||
| void load(const QString &channelName, std::weak_ptr<Channel> channelPtr, | ||
| ResultCallback onLoaded, ErrorCallback onError) |
There was a problem hiding this comment.
warning: the parameter 'onLoaded' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| ResultCallback onLoaded, ErrorCallback onError) | |
| const ResultCallback& onLoaded, ErrorCallback onError) |
src/providers/recentmessages/Api.hpp:32:
- ResultCallback onLoaded, ErrorCallback onError);
+ const ResultCallback& onLoaded, ErrorCallback onError);| using namespace recentmessages::detail; | ||
|
|
||
| void load(const QString &channelName, std::weak_ptr<Channel> channelPtr, | ||
| ResultCallback onLoaded, ErrorCallback onError) |
There was a problem hiding this comment.
warning: the parameter 'onError' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| ResultCallback onLoaded, ErrorCallback onError) | |
| ResultCallback onLoaded, const ErrorCallback& onError) |
src/providers/recentmessages/Api.hpp:32:
- ResultCallback onLoaded, ErrorCallback onError);
+ ResultCallback onLoaded, const ErrorCallback& onError);
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
This exposes internal functions for testing by splitting the implementation & internal API into separate files
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
This exposes internal functions for testing by splitting the implementation & internal API into separate files
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This exposes internal functions for testing by splitting the implementation & internal API into separate files