Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.4.5 #4787

Merged
merged 3 commits into from
Aug 26, 2023
Merged

Release v2.4.5 #4787

merged 3 commits into from
Aug 26, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Aug 26, 2023

In the release PR

  • Updated version code in src/common/Version.hpp
  • Updated version code in CMakeLists.txt
    This can only be "whole versions", so if you're releasing 2.4.0-beta you'll need to condense it to 2.4.0
  • Add a new release at the top of of the releases key in resources/com.chatterino.chatterino.appdata.xml
    This cannot use dash to denote a pre-release identifier, you have to use a tilde instead.
  • Updated version code in .CI/chatterino-installer.iss
  • Update the changelog ## Unreleased section to the new version CHANGELOG.md
    Make sure to leave the ## Unreleased line unchanged for easier merges

After the PR has been merged

  • Tag the release
  • Manually run the create-installer workflow.
    This is only necessary if the tag was created after the CI in the main branch finished.
  • Start a manual Launchpad import - scroll down & click Import Now
  • Make a PPA release to this repo with the debchange command.
    debchange -v 2.4.0 then add the changelog entries
    debchange --release then change the distro to be unstable

@pajlada
Copy link
Member Author

pajlada commented Aug 26, 2023

Looks good to me 👍
image

@pajlada pajlada merged commit 05a72d3 into master Aug 26, 2023
15 of 16 checks passed
@pajlada pajlada deleted the chore/release-v2.4.5 branch August 26, 2023 10:33
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -24,7 +24,7 @@
* - 2.4.0-alpha.2
* - 2.4.0-alpha
**/
#define CHATTERINO_VERSION "2.4.4"
#define CHATTERINO_VERSION "2.4.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: macro 'CHATTERINO_VERSION' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]

#define CHATTERINO_VERSION "2.4.5"
        ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants