Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new Get Channel Followers Helix endpoint, fixing follower count not showing up in usercards #4809

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Sep 9, 2023

Description

Fixes #4808

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

mocks/include/mocks/Helix.hpp Show resolved Hide resolved
}

// Forward "message" from Twitch
HelixError error(root);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'error' of type 'chatterino::HelixError' can be declared 'const' [misc-const-correctness]

Suggested change
HelixError error(root);
HelixError const error(root);

@pajlada pajlada enabled auto-merge (squash) September 9, 2023 12:10
@pajlada
Copy link
Member Author

pajlada commented Sep 9, 2023

image

@pajlada pajlada merged commit 813d968 into master Sep 9, 2023
16 checks passed
@pajlada pajlada deleted the chore/helix-follower-count-migration branch September 9, 2023 12:51
pajlada added a commit that referenced this pull request Sep 28, 2023
pajlada added a commit that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User card followers count using the deprecated helix endpoint
1 participant