Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QuickSwitcherPopup now pops up in the selected window #4819

Merged
merged 7 commits into from
Sep 17, 2023
Merged

fix: QuickSwitcherPopup now pops up in the selected window #4819

merged 7 commits into from
Sep 17, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Sep 16, 2023

Description

  • fix: QuickSwitcherPopup now pops up in the selected window
  • QuickSwitcherPopup: reduce indentation anon namespace
  • QuickSwitcherPopup: constexpr the minimum size
  • QuickSwitcherPopup: remove redundant virtual from themeChangedEvent

@pajlada pajlada requested a review from Mm2PL September 16, 2023 11:54
@pajlada
Copy link
Member Author

pajlada commented Sep 16, 2023

@Mm2PL I removed one of the questionable usages of getMainWindow, could you take a look at this PR? Only the first commit makes actual behavioral changes

Related to #4816

github-actions[bot]
github-actions bot reviewed Sep 16, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/Window.cpp Show resolved Hide resolved
src/widgets/dialogs/switcher/QuickSwitcherPopup.cpp Show resolved Hide resolved
Mm2PL
Mm2PL requested changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening a new channel in a tab still uses the main window. Can you fix that? It is located in src/widgets/dialogs/switcher/NewTabItem.cpp.

@pajlada
Copy link
Member Author

pajlada commented Sep 17, 2023

Opening a new channel in a tab still uses the main window. Can you fix that? It is located in src/widgets/dialogs/switcher/NewTabItem.cpp.

2b75961 (#4819) should fix this. I have tested it but would be good with a sanity check. Good catch!

Mm2PL
Mm2PL approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep works as expected now.

@Mm2PL Mm2PL enabled auto-merge (squash) September 17, 2023 21:17
@Mm2PL Mm2PL merged commit e6df652 into master Sep 17, 2023
17 checks passed
@Mm2PL Mm2PL deleted the fix/quick-switcher-popup-use-the-right-window branch September 17, 2023 21:52
This was referenced Sep 19, 2023
Closed
Closed
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Mm2PL Mm2PL Mm2PL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pajlada @Mm2PL