fix: Commands now completable when not starting with / #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
approved these changes
Sep 30, 2023
Felanbird
added a commit
to Felanbird/chatterino2
that referenced
this pull request
Oct 9, 2023
…erino#4846)" This reverts commit 4d8b623.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced in #4639. When we can't determine the kind of item being tab-completed, we now consider emotes, usernames, and commands.
Fixes #4842
Truthfully I didn't even know you could create a command without a slash 😅
Implementation
This fix was a bit more complicated than I had expected due to the
userCompletionOnlyWithAtsetting. When we can't deduce the kind of item being completed, depending on this setting, we either:To reduce code duplication, I modified
UnifiedSourceto accept a vector of sources to combine instead of being hardcoded to just combine emotes and usernames.