Check VCRT and show installed/shipped version #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornes
reviewed
Sep 29, 2023
.CI/chatterino-installer.iss
Outdated
| @@ -56,7 +65,8 @@ SetupWindowTitle=Setup - %1 (Nightly) | |||
| #endif | |||
|
|
|||
| [Tasks] | |||
| Name: "vcredist"; Description: "Install the required Visual C++ 2015/2017/2019/2022 Redistributable"; | |||
| ; Only show this option if the VCRT can be updated. | |||
| Name: "vcredist"; Description: "Install the required Visual C++ 2022 Redistributable ({code:VCRTDescription})"; Check: NeedsNewVCRT(); | |||
There was a problem hiding this comment.
maybe instead of hardcoding Visual C++ 2022 Redistributable we could use VersionInfo.Product here?
it resolves to Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.36.32532, would save some maintenance in future
There was a problem hiding this comment.
Thank you! I was actually looking for something like this.
There was a problem hiding this comment.
Hmm, VersionInfo.Product doesn't seem to return anything for me (even though it's shown when stringifying the version info), so I used VersionInfo.FileDescription.
There was a problem hiding this comment.
both Product and FileDescription have same content on all versions i had on hand, so should be fine
pajlada
approved these changes
Sep 30, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For testing, you can change
Bldto a lower number inHKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\x64and/or rename it (orVersion) to simulate the case where it's not installed.Aside: The installer currently doesn't have the option to specify the installation directory. I'm not sure if that's intentional.
DisableDirPage=falsecan be added to show the page.