Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invisible widgets when hit testing #4873

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Oct 6, 2023

Description

Randomly found that we're hit testing invisible widgets (the update button). I added a check to frameless popups as well (although I don't think there are invisible widgets currently).

Since I made changes in the main hit testing anyway, I reordered the checks, so the largest area (→ most likely location of the cursor) gets tested first.

Fixes #1967.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

Co-authored-by: Felanbird <[email protected]>
@pajlada pajlada enabled auto-merge (squash) October 6, 2023 21:24
@pajlada pajlada merged commit 7528257 into Chatterino:master Oct 6, 2023
15 checks passed
@Nerixyz Nerixyz deleted the fix/invis-drag branch October 6, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part of the title bar can't be dragged
3 participants