fix: Remove tab completion caching of source #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
he meant to comment on this PR |
Felanbird
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
had someone toggle a 7tv emote for me, and an old version I had did have a problem removing it from the tab completion, this PR does not have that problem
username tab completion also seems to be fixed, I tested in a similar way as I reported, but not absolutely perfectly as moonmoon is live and idk who else's offline chat is that correct level of active, but it seemed correct
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were being a little too clever and trying to cache the emote source for later reuse. Unfortunately, when a new user chats for the first time, their username would not be included in the available completion list until they type something else before attempting a completion again.
The same goes for emotes added via the EventAPI.
Fixes #4878
Fixes #4892