Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run tests on Windows & macOS in CI #4970

Merged
merged 101 commits into from
Nov 18, 2023

Conversation

Wissididom
Copy link
Contributor

@Wissididom Wissididom commented Nov 17, 2023

Description

  • Windows: Docker can only run Windows Containers, so the PubSub Server and httpbin needed to be run manually in the background. First I tried using the repository that was used inside the docker image of the ubuntu test workflow, but that wasn't easy and pajlada suggested using httpbin-rs. That just didn't have the $HOST/status/{code} endpoints, so I searched for alternatives and found httpbox, which I then used.
  • macOS: Using Colima to make Docker work. Without it, I get Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
  • macOS: Use beta macos-13 to make the C++20 code work.
  • Ubuntu: Add --output-on-failure to the workflow to see where the problem is if a test fails. Initially done to find a problem during playing around with it, but I think I can be helpful for later, so I kept it.

Occasional Problem

  • Sometimes the macOS Qt6 workflow fails with error Subprocess aborted at different cases but I don't know why that might be. For me, it was always fixed after re-running the workflow.

Thought

To not have to use Docker and Colima on macOS, I could build the pubsub server and the httpbox tool on macOS in background too I think, but that probably won't make a difference I think.

Closes #4780

.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Outdated Show resolved Hide resolved
.github/workflows/test-macos.yml Outdated Show resolved Hide resolved
.github/workflows/test-windows.yml Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks for the macOS file - overall this looks good 👍

.github/workflows/test-macos.yml Outdated Show resolved Hide resolved
.github/workflows/test-macos.yml Outdated Show resolved Hide resolved
.github/workflows/test-macos.yml Outdated Show resolved Hide resolved
.github/workflows/test-macos.yml Outdated Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from my perspective, I imagine the cache using the same as the build script should be ok - @Nerixyz is is double-checking before this is merged in

Copy link
Contributor

@Nerixyz Nerixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pajlada pajlada changed the title Create Windows and MacOS test workflow feat: Run tests on Windows & macOS in CI Nov 18, 2023
@pajlada pajlada merged commit 7898b97 into Chatterino:master Nov 18, 2023
18 of 19 checks passed
@Wissididom Wissididom deleted the split-tests branch November 18, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests in CI on Windows & macOS
3 participants