Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only display spaces between words in reply context #4977

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 25, 2023

Description

There were some bugs regarding spaces and emojis in the reply context (a missing one before an emoji in abc 😂 def and an invalid one in abc😂def).

This PR fixes the bugs and adds tests for emoji parsing.


  • Emoji parsing still uses a boost::variant, is that still necessary?
  • The EmojiMap emojis in Emojis can be a std::vector, since the key is only used in tests and benchmarks.

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Nov 25, 2023

Not sure what the Windows 5.15 issue is (I suspect it's my [telegram's] qstringliteral).

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Nov 26, 2023

Not sure what the Windows 5.15 issue is (I suspect it's my [telegram's] qstringliteral).

I should've read the logs.

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Nov 26, 2023

Seems like the highlight controller test is broken.

@Wissididom
Copy link
Contributor

Seems like the highlight controller test is broken.

Yeah, we noticed it when creating the tests. With Qt 6.2.4 it seemed to have worked but with Qt 6.5.0 it times out. I played around with it here: Wissididom#19

@Nerixyz
Copy link
Contributor Author

Nerixyz commented Nov 26, 2023

Yeah, we noticed it when creating the tests. With Qt 6.2.4 it seemed to have worked but with Qt 6.5.0 it times out. I played around with it here: Wissididom#19

Off-topic: We probably want to run tests in debug mode on macOS and Windows as well.

@pajlada pajlada changed the title Only display spaces between words in reply context fix: Only display spaces between words in reply context Nov 26, 2023
@pajlada pajlada merged commit 854032f into Chatterino:master Nov 26, 2023
18 of 19 checks passed
@Nerixyz Nerixyz deleted the fix/reply-emoji branch November 26, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants