Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sound and flash alert for automod caught messages #5026

Merged
merged 23 commits into from
Dec 25, 2023

Conversation

iProdigy
Copy link
Contributor

@iProdigy iProdigy commented Dec 15, 2023

When automod split isn't present in the current tab (or chatterino is minimized), moderators may not realize an automod caught message has been received. This PR allows a sound notification and/or taskbar flash upon receiving a caught message

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would rather see this be a new "default" bar in the Highlights settings section, and it functioning more closely to a highlight.

Let me know if I'm missing some context that makes that stupid

@iProdigy iProdigy marked this pull request as draft December 16, 2023 19:53
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/controllers/highlights/HighlightModel.cpp Outdated Show resolved Hide resolved
src/controllers/highlights/HighlightPhrase.cpp Outdated Show resolved Hide resolved
src/controllers/highlights/HighlightPhrase.hpp Outdated Show resolved Hide resolved
@iProdigy
Copy link
Contributor Author

While the new default highlight row has been added, this PR is still a draft since automod messages don't work through SharedMessageBuilder, so HighlightController::check is never called - will follow-up with a refactor that addresses this

@iProdigy iProdigy changed the title feat: trigger sound and highlight for automod channel feat: add sound and flash alert for automod caught messages Dec 25, 2023
@iProdigy iProdigy marked this pull request as ready for review December 25, 2023 05:39
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that's questionable to me right now is the color
For other highlights, this colors both the message itself & the scrollbar.
For this, we only color the scrollbar.
Maybe it's best to just leave out the color entirely until we figure out what makes most sense?

@iProdigy
Copy link
Contributor Author

Yeah I'm not tied to having any scrollbar color (old caught messages are likely to be unactionable anyways), so we can remove it for now (and changing the message background could look strange)

@pajlada pajlada enabled auto-merge (squash) December 25, 2023 23:01
@pajlada pajlada merged commit eb12cfa into Chatterino:master Dec 25, 2023
20 checks passed
@iProdigy iProdigy deleted the feature/automod-notification branch December 25, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants