-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve color selection and display #5057
Improve color selection and display #5057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 47. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 26. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
please drop support now
Some quick feedback
|
The recent colors are just the colors of the message and user highlights. So if you have more entries with different colors, you'll have more recently used colors.
Added.
I added the opaque color, but it doesn't really make much of a difference. At least in the alpha slider, I think it's better to be transparent. Doing it the way it's done on the web isn't as easy, as we need to add another mask when painting the checkerboard (which seems overkill). |
Can revert the circle opaque color in that case, it was probably fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not the biggest hassle, I'd like to get rid of the ColorSelect
"widget" (and maybe even the ColorDetails) and just add them straight to the ColorPickerDialog - going through the anatomy of the dialog has been a few too many classes deep imo, maybe that will make it a bit simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one quick review question & I'm happy to merge this in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
This PR improves color selection and display by doing the following changes:
#rgb
,#rrggbb
, and#rrggbbaa
(this is the CSS one, not the Qt one)same for users and badges
I'm still not sure about the rounding of the widgets and the circle selector, so feedback is welcome!