fix: ignore save requests after closing all windows #5081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098.
WindowManager::save
is called two times when closing all windows:chatterino2/src/widgets/Window.cpp
Lines 135 to 142 in 1554d7b
chatterino2/src/Application.cpp
Lines 335 to 341 in 1554d7b
The second save doesn't see the closed child windows if all windows were closed with
closeAll
. So aftercloseAll
is called, the window manager will now ignore all save events.