fix: assert for GUI thread in getters instead of get(I)App
#5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
changed the title
Paths and Args into special supertypeget(I)App
pajlada
approved these changes
Jan 18, 2024
1 task
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getIAppandgetAppcan only be called from the GUI thread, as they contain singletons that expose functionality only available in the GUI thread. I'm adding agetCAppthat returns a subset ofIApplicationwhich is safe to use outside the GUI thread. It should be obvious, thatconst &Pathsandconst &Argsare safe to use outside the GUI thread [as long as no one keeps a&Path/&Argsand they have been initialized].Not sure how to call the new supertype. I was thinking of "C" for "concurrent".