feat: add system theme on Qt 6.5 and up #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
feat/system-theme
branch
from
fa078bf
to
5c28c8b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I would like to see this use a few more settings in the backend to control
The UX might be a bit tricky to get right, so let's keep it simple in this first iteration & just add the checkbox/selector straight up to the settings page. |
Nerixyz
force-pushed
the
feat/system-theme
branch
from
5c28c8b
to
c5a8002
Compare
pajlada
approved these changes
Jan 27, 2024
1 task
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
* feat: add system theme on Qt 6.5 * chroe: add changelog entry * refactor: add separate settings * fix: qt 5 * Update changelog entry --------- Co-authored-by: Rasmus Karlsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #2452 (comment), Qt 6.5 added a signal for the system color scheme. The system theme I added is a dummy theme that resolves to the correct theme once
updateis called.NVIDIA_Share_2024-01-21_11-55-24.mp4
Closes #2452.