perf: add signal to invalidate buffers without doing layout #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
reviewed
Jan 23, 2024
Nerixyz
changed the title
|
I noticed that invalidating is better than deleting, since we know the width of the message didn't change. This way we can re-use the old buffer. |
pajlada
approved these changes
Jan 24, 2024
1 task
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to fix a bug in the 7TV fork related to paints and noticed that I needed a way to just invalidate the paint buffers but not do layout (if it's not needed).
This PR adds a signal similar to
layoutRequestedthat tells channel-views to discard the paint buffers. This is done by setting a flag when doing (re-)layout.I noticed two settings that benefit from this: Alternate background color and Separate with lines. You can test this PR by toggling the settings.