chore: specialize Atomic<std::shared_ptr<T>>
#5133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #5128 refactors message parsing, it would be nice to do that off the main thread. To do this safely, we can utilize the
Atomic
class to provide shared state for workers (similar to theMessageLayoutContext
).C++ 20 added
std::atomic<std::shared_ptr<T>>
. Not every standard library implementation has added this yet, so it's behind an#ifdef
. To ensure sane use,Atomic<std::shared_ptr<T>>
requiresT
to beconst
(otherwise the atomic is kinda useless). Since only the MSVC STL and GCC libstdc++ implement this and ship in compiler versions that have concepts, it's fine to require these too.Neither implementation is lock-free, but both are better than using a
std::mutex
(e.g. the implementation in the STL spins on a single bit compared to a mutex which uses a shared read-write lock).