Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltips showing out-of-bounds after loading images #5186

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Feb 18, 2024

This fixes #2007 (I guess "doesn't fix #X" counts as fixing).

When calling (showAnd)moveTo on BaseWindow, the last arguments are now saved and can be reused to recheck the bounds in applyLastBoundsCheck (no-op if moveTo was never called or called without performing a bounds-check). This is called when loading an image in the tooltip and when updating the link-tooltip after it changed.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on i3 on Arch Linux btw

@pajlada pajlada enabled auto-merge (squash) February 24, 2024 11:27
@pajlada pajlada merged commit dd61482 into Chatterino:master Feb 24, 2024
17 checks passed
@Nerixyz Nerixyz deleted the fix/tooltip-oob branch February 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emote tooltip window can go out of screen bounds on first draw
2 participants