fix: tooltips showing out-of-bounds after loading images #5186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2007 (I guess "doesn't fix #X" counts as fixing).
When calling
(showAnd)moveTo
onBaseWindow
, the last arguments are now saved and can be reused to recheck the bounds inapplyLastBoundsCheck
(no-op ifmoveTo
was never called or called without performing a bounds-check). This is called when loading an image in the tooltip and when updating the link-tooltip after it changed.