Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add /announce[color] commands #5250

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

4rneee
Copy link
Contributor

@4rneee 4rneee commented Mar 13, 2024

This adds support to send the /announce[color] commands.
Resolves sending part for #5218.
Note that Chatterino currently does not support receiving colored highlights, so the color is currently only visible in the browser chat.

Screenshot:
announce

Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't necessarily like having a ton of commands one for each color, this is how Twitch does it and commands are expected to work the mostly same on every client.
Looks good to me.
I edited the PR description, so the issue wouldn't be closed when this is merged.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, otherwise looks good to me

@pajlada pajlada changed the title Feature: add /announce[color] commands feat: add /announce[color] commands Mar 14, 2024
@pajlada pajlada merged commit fc61e8d into Chatterino:master Mar 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants