-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update color of usernames & boldness of usernames on the fly #5300
Conversation
Boldness was already covered before :)
7cf5bbc
to
4066468
Compare
This should be ready for a review now @Mm2PL if you want to take a peek To test, mention a user in a normal & a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on Twitch and IRC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A mistake was made: I can't copy username text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(misclick)
This ensures it's included in other text-like things, and not excluded
…usernames-on-the-fly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything including copying messages works now. LGTM
Boldness was already covered before
Fixes #2637