Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove "Show chatter list" entry from split header menu for non-mods #5336

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix: Remove "Show chatter list" entry from split header menu for non-mods #5336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Bugfix: Fixed links having `http://` added to the beginning in certain cases. (#5323)
- Bugfix: Fixed topmost windows from losing their status after opening dialogs on Windows. (#5330)
- Bugfix: Fixed a gap appearing when using filters on `/watching`. (#5329)
- Bugfix: Removed the remnant "Show chatter list" menu entry for non-moderators. (#5336)
- Dev: Changed the order of the query parameters for Twitch player URLs. (#5326)

## 2.5.0-beta.1
Expand Down
9 changes: 6 additions & 3 deletions src/widgets/splits/SplitHeader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,9 +525,12 @@ std::unique_ptr<QMenu> SplitHeader::createMainMenu()

if (twitchChannel)
{
moreMenu->addAction(
"Show chatter list", this->split_, &Split::showChatterList,
h->getDisplaySequence(HotkeyCategory::Split, "openViewerList"));
if (twitchChannel->hasModRights())
{
moreMenu->addAction(
"Show chatter list", this->split_, &Split::showChatterList,
h->getDisplaySequence(HotkeyCategory::Split, "openViewerList"));
}

moreMenu->addAction("Subscribe", this->split_, &Split::openSubPage);

Expand Down
Loading