Add custom image functionality for inline mod buttons. #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove commented out code, - remove useless if
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
reviewed
Apr 29, 2024
Comment on lines
36
to
39
| loadPixmapFromUrlLazy( | ||
| (*item.getImage())->url(), [row](const QPixmap &pixmap) { | ||
| row[Column::Icon]->setData(pixmap, Qt::DecorationRole); | ||
| }); |
There was a problem hiding this comment.
This should ensure the reference to row remains valid. Furthermore, setData should be called on the GUI thread.
if iconPath is present, getImage will always be valid.
This should be noted in a comment.
There was a problem hiding this comment.
I don't think we can even check if row is valid. I can't make it a smart pointer without a large refactor. I could look up the row by some kind of unique temporary ID, but it seems like a hack.
src/util/LoadPixmapLazy.cpp
Outdated
| if (!reader.canRead() || reader.size().isEmpty()) | ||
| { | ||
| qCWarning(chatterinoSettings) | ||
| << "Can't read mod action image at" << url.string << ":" |
There was a problem hiding this comment.
- This mentions a mod action image, but the function is more general (it can read any image).
- This will add a space between the URL and the colon (same as below).
There was a problem hiding this comment.
It does add a space, to be honest I don't care that much about that space.
Mm2PL
force-pushed
the
feature/inline-mod-button-custom-images
branch
from
d59967c
to
d9ff6ca
Compare
- now uses QPointer to ensure the view is valid - now calls the code on the main thread to never hit an assertion
…re/inline-mod-button-custom-images
pajlada
reviewed
May 4, 2024
i hate naming things
with their icon & line
chatterinoImage
pajlada
approved these changes
May 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also cleans up ModerationAction code