Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: global emotes not loading #5435

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix: global emotes not loading #5435

merged 3 commits into from
Jun 3, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jun 3, 2024 •
edited
Loading

  • fix: manually initialize twitchircserver after rest of singletons are initialized
  • unrelated nit: remove copy/move ctors/operators of twitchircserver

Fixes #5434

@pajlada
fix: manually initialize twitchircserver after rest of singletons are…
51e0845 
… initialized

this fixes global emotes not being loaded on startup, since initialize
was never called (since it was no longer added to the singleton list)
@pajlada
unrelated nit: remove copy/move ctors/operators of twitchircserver
2337d66
@pajlada
update changelog entry
5264eab
@pajlada pajlada merged commit 248cd46 into master Jun 3, 2024
17 checks passed
@pajlada pajlada deleted the fix/twitchircserver-not-being-initialized branch June 3, 2024 08:31
@Nerixyz Nerixyz mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3rd Party Global Emotes not loading on app launch
1 participant
@pajlada