-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup, document, and test some RTL code #5473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
commented
Jun 18, 2024
src/messages/Image.cpp
Outdated
@@ -60,7 +60,7 @@ Frames::Frames(QList<Frame> &&frames) | |||
return init + frame.duration; | |||
}); | |||
|
|||
if (totalLength == 0) | |||
if (totalLength <= 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not worth another PR imo.
pajlada
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at cleaning up the RTL code and documentation a bit so it's easier to understand (that's subjective, I know).
containsRTL
tolineContainsRTL_
and checked forlineContainsRTL_ || isRTL()
inbreakLine
.This way, a few RTL words in a wrapped LTR message won't affect the lines below.
first
andFirstWord
totextDirection_
andDirection
respectively.That's what they are about.
first
also "leaks" how it's detected (finding the first word that has a direction).isRTL
,isLTR
, andisNeutral
to check the text direction.int
tosize_t
andqsizetype
(for signed values).addElement
to check for weird usages of elements.QVarLengthArray
.Single lines usually have very few elements, so we can store them on the stack (if that's not enough, the container will allocate).
wasPrevReversed_
from a member to a local variable (isReversing
)addElement
andreorderRTL
(and the other stuff I added)The tests only test the reordering on a single line. The line must have a username element.
They're still a bit WIP, as e.g. images and mentions aren't tested.