fix(windows): wait for Qt before getting bounds #5478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't use the bounds provided by
WM_SIZE
itself to account for Qt's High-DPI scaling, we need to wait for Qt to have processed the message before saving our bounds. Technically, this could use the bounds we get fromGetClientRect
and emulate Qt's scaling, but I don't think that's smart (because Qt might change stuff, etc...).postToThread
isn't the best name for this use-case, because we're only interested in queuing an event after Qt has processed the native message. It's more likenextTick
or ratherendOfThisTick
orbeforeNextTickButAfterAllCurrentEvents
.The same is done for
WM_MOVE
which needs to be processed by Qt.Things to test
Fixes #5477.