Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to log streams by their ID, allowing for easier "per-stream" log analyzing #5507

Merged
merged 12 commits into from
Jul 14, 2024

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jul 13, 2024

Fixes #5386

this will create a new file in the channel's log directory, with the
filename based on the stream ID, and write messages there too

No date is included, since a stream can span multiple days
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/singletons/helper/LoggingChannel.cpp Outdated Show resolved Hide resolved
@pajlada
Copy link
Member Author

pajlada commented Jul 13, 2024

Will merge this in tomorrow if anyone wants to take a look, otherwise ipaja

Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pajlada pajlada enabled auto-merge (squash) July 14, 2024 09:19
@pajlada pajlada merged commit 9788d0f into master Jul 14, 2024
17 checks passed
@pajlada pajlada deleted the feat/add-setting-to-log-stream-logs branch July 14, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant