Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure liveupdate pubsubs exit #5557

Merged
merged 5 commits into from
Aug 24, 2024
Merged

fix: ensure liveupdate pubsubs exit #5557

merged 5 commits into from
Aug 24, 2024

Commits on Aug 24, 2024

  1. fix: ensure liveupdate pubsubs exit

    @pajlada
    pajlada committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    1326062 View commit details
    Browse the repository at this point in the history

  2. fix: call stop from derived class 

    Previously, the derived class (i.e. BttvLiveUpdates or SeventvEventAPI)
    would have their destructor ran before BasicPubSubManager called
    stop, meaning there was a time wherein messages could still flow
    through, attempting to call `onMessage` on a pure virtual, causing a
    crash.
    @pajlada
    pajlada committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a900502 View commit details
    Browse the repository at this point in the history

  3. fix: disable client size assert 

    This can reliably fail if the thread join fails
    @pajlada
    pajlada committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    4a6aa04 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into fix/rip-out-liveupd… 

    …ate-websocket-clients-if-they-dont-stop
    @pajlada
    pajlada committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a7b5574 View commit details
    Browse the repository at this point in the history

  5. fix: allow stop to be called multiple times, but only letting first 

    stop do something

this makes it easier to test things
    @pajlada
    pajlada committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a4440b1 View commit details
    Browse the repository at this point in the history