Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up some of the pronoun implementation #5583

Merged
merged 7 commits into from
Sep 8, 2024
Merged

chore: clean up some of the pronoun implementation #5583

merged 7 commits into from
Sep 8, 2024

Commits on Sep 8, 2024

  1. nit: remove unused pronoun definition in benchmarks

    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fe603dc View commit details
    Browse the repository at this point in the history

  2. nit: make App::pronouns a unique ptr

    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    46dd502 View commit details
    Browse the repository at this point in the history

  3. nit: newline

    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7888a02 View commit details
    Browse the repository at this point in the history

  4. nit: refactor Pronouns.hpp/cpp 

    getCachedUserPronoun can be private

renamed fetch into getUserPronoun
    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    a2bd696 View commit details
    Browse the repository at this point in the history

  5. chore: refactor PronounsAlejoApi

    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    bb2a012 View commit details
    Browse the repository at this point in the history

  6. nit: rename pronouns to userPronoun

    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4e8d132 View commit details
    Browse the repository at this point in the history

  7. update changelog entry

    @pajlada
    pajlada committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    29f3a89 View commit details
    Browse the repository at this point in the history