Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup some parts of qmagicenum #5587

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Sep 9, 2024

  • Removes enable_ifs over concepts (return types are a bit more readable this way)
  • Ports magic_enum's is_nothrow_invocable to predicates over QChar
  • Adds some comments to the storage
  • Moves static string construction to detail
  • Removes usage of magic_enum::detail::enum_subtype - this is resolved by magic_enum (except for enumFlagsName, where we verify the type)
  • Removes inline for constexpr functions
  • Adds two more members to the flags test that live outside the regular enum range (-128…128)

@pajlada pajlada merged commit 2afa227 into Chatterino:master Sep 9, 2024
18 checks passed
@Nerixyz Nerixyz deleted the chore/qmagicenum branch September 9, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants