chore: ensure statics are only present once in the final app
#5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
force-pushed
the
fix/storage
branch
from
9dd37f1
to
8122d81
Compare
pajlada
reviewed
Sep 14, 2024
pajlada
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
staticshouldn't be used for constants (nor functions) in headers, as this causes them to be compiled separately into every TU they're included in. For small constants, it's not that bad, but for more complex types, this requires initialization for each of these instances (e.g. aQStringneeds to be constructed by calling into the respective library - LTO can't eliminate this). These constants should be defined asinline, meaning they will essentially be "merged" into a single constant when linking (inlinedoesn't really mean that the compiler will inline them).Even though
constexprimpliesinlinefor functions, it doesn't implyinlinefor constants (these will default tostatic).