Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve handling of shared chat messages #5606

Merged
merged 17 commits into from
Oct 5, 2024

Conversation

iProdigy
Copy link
Contributor

@iProdigy iProdigy commented Sep 28, 2024

  • Suppress most USERNOTICEs to avoid confusing broadcasters
  • Avoid duplicate pings on PRIVMSG (note: duplicate pings are still possible if 2+ channels in the shared chat session are joined but there is 1+ channel in the session the user has not joined)
  • Add search flags

this branch currently doesn't render the source channel information in the ui; will try to get to that in a separate PR

known limitation: channel-specific cheermotes and third-party emotes require the source channel to also be joined to render as an image

@iProdigy iProdigy marked this pull request as ready for review September 28, 2024 20:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/messages/MessageBuilder.cpp Outdated Show resolved Hide resolved
src/messages/MessageBuilder.cpp Outdated Show resolved Hide resolved
src/messages/MessageBuilder.cpp Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) October 5, 2024 10:09
@pajlada pajlada merged commit 06d9a37 into Chatterino:master Oct 5, 2024
18 checks passed
@iProdigy iProdigy deleted the feature/shared-chat branch October 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants