Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't initialize GIFTimer in tests #5608

Merged
merged 4 commits into from
Sep 29, 2024
Merged

fix: don't initialize GIFTimer in tests #5608

merged 4 commits into from
Sep 29, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Sep 29, 2024

From #5603:

While testing, I noticed that Emotes initializes the GIFTimer which could cause it to invoke the repaint event which tries to access the window manager.

Not sure what the exact conditions are, but now it can't happen anymore (my pc might be a bit slow).

github-actions[bot]
github-actions bot reviewed Sep 29, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

tests/src/SplitInput.cpp Outdated Show resolved Hide resolved
@pajlada pajlada merged commit 0db4776 into Chatterino:master Sep 29, 2024
16 of 17 checks passed
@Nerixyz Nerixyz deleted the fix/gif-init branch September 29, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada