Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(luals-meta): Use opaque enum values and correct HTTP types #5682

Merged
merged 4 commits into from
Nov 2, 2024
Merged

fix(luals-meta): Use opaque enum values and correct HTTP types #5682

merged 4 commits into from
Nov 2, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Oct 28, 2024

Does what the title says:

  • Uses opaque values for enums (i.e. it doesn't expose which type the values are)
  • Prefixes HTTP types with c2 and adds return values for HTTPResponse accessors

@pajlada pajlada enabled auto-merge (squash) November 2, 2024 10:56
@pajlada pajlada merged commit ecfb35c into Chatterino:master Nov 2, 2024
18 checks passed
@Nerixyz Nerixyz deleted the fix/lua-meta-thing branch November 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada