Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cli args to support rules listing, include, exclude #28

Closed
kaplanlior opened this issue Mar 29, 2023 · 1 comment · Fixed by #113
Closed

add cli args to support rules listing, include, exclude #28

kaplanlior opened this issue Mar 29, 2023 · 1 comment · Fixed by #113
Assignees
@baruchiro
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kaplanlior
Copy link
Contributor

kaplanlior commented Mar 29, 2023 •
edited by baruchiro
Loading

Today we run the full list of rules as defined at secrets/secrets.go#L111

Add the following sub-commands to the list command to all the user know which rules are available:
rules - list rules

Add the following flags for the scan command to allow the user to control which rules are being used:

--all-rules (default)
--rule-include string, comma separated (adds to list, starts from empty)
--rule-exclude string, comma separated (remove from list, starts from full list)
@kaplanlior kaplanlior changed the title Add support for rules listing, includtion / exclusion Feature: Add support for rules listing, includtion / exclusion Mar 29, 2023
@jossef jossef changed the title Feature: Add support for rules listing, includtion / exclusion add cli args to support rules listing, include, exclude Mar 30, 2023
@jossef jossef added the enhancement New feature or request label Mar 30, 2023
@baruchiro baruchiro mentioned this issue Jun 12, 2023
Closed
@baruchiro baruchiro added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 26, 2023
@baruchiro
Copy link
Contributor

@kaplanlior I understand that all these flags are mutually exclusive.

@baruchiro baruchiro mentioned this issue Jun 27, 2023
Merged
baruchiro pushed a commit that referenced this issue Jun 27, 2023
feat: include and exclude rules
aa2b7d4 
Close #28
jossef added a commit that referenced this issue Jun 28, 2023
@jossef
feat: include and exclude rules (#113)
7953f50 
- fix: don't try to scan util commands
- feat: print all rules with their tags
- ci: check needed go mod tidy
- chore: find duplicate rules
- feat: include and exclude rules

Closes #28

---------

Co-authored-by: Jossef Harush Kadouri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baruchiro baruchiro

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
2ms
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: include and exclude rules Checkmarx/2ms
3 participants
@jossef @kaplanlior @baruchiro