Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: accept also arguments splitted by comma #103

Merged
merged 1 commit into from
Jun 22, 2023
Merged

chore: accept also arguments splitted by comma #103

merged 1 commit into from
Jun 22, 2023

Conversation

baruchiro
Copy link
Contributor

@baruchiro baruchiro commented Jun 22, 2023 •
edited
Loading

Replaced:

StringArray: The value of each argument will not try to be separated by comma. Use a StringSlice for that.

With:

StringSlice: Compared to StringArray flags, StringSlice flags take comma-separated value as arguments and split them accordingly. For example:

--ss="v1,v2" --ss="v3"
will result in

[]string{"v1", "v2", "v3"}

@github-actions
Copy link

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@baruchiro baruchiro mentioned this pull request Jun 22, 2023
Merged
@jossef jossef merged commit fba16b7 into master Jun 22, 2023
7 checks passed
@jossef jossef deleted the move-to-string-array branch June 22, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jossef jossef jossef approved these changes

@joaopedrocsilva joaopedrocsilva Awaiting requested review from joaopedrocsilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baruchiro @jossef