fix: report directory is not exist #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
baruchiro
reviewed
Feb 18, 2024
baruchiro
reviewed
Feb 18, 2024
baruchiro
reviewed
Feb 18, 2024
baruchiro
suggested changes
Feb 18, 2024
nargov
force-pushed
the
report-path-creation
branch
from
39f09aa
to
309dc3c
Compare
nargov
force-pushed
the
report-path-creation
branch
from
309dc3c
to
cc922e2
Compare
baruchiro
approved these changes
Feb 18, 2024
baruchiro
changed the title
baruchiro
changed the title
baruchiro
reviewed
Feb 18, 2024
auto-merge was automatically disabled
February 18, 2024 18:28
Head branch was pushed to by a user without write access
|
Funny, it failed on permission for writing to the temp folder. |
auto-merge was automatically disabled
February 18, 2024 20:10
Head branch was pushed to by a user without write access
nargov
force-pushed
the
report-path-creation
branch
from
b2f3ebf
to
d39383d
Compare
|
I tested it on #209 and if you set the permission of I think |
nargov
force-pushed
the
report-path-creation
branch
from
d39383d
to
8ec48b4
Compare
baruchiro
approved these changes
Feb 20, 2024
|
Well done and huge thanks! BTW, why do you force push every time? |
|
To keep the history to a single commit (I use commit --amend, and it requires rewriting the branch history). :) I'll try something else soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200
I would usually start a discussion about a change before starting, but since this was just a tiny fix I skipped it this time. Hope that's Ok.
This adds a path existence check to the path(s) passed in and ensures the directory exists.
I submit this contribution under the Apache-2.0 license.