CLI | Add Vorpal Engine Logic (AST-38523) #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Policy Management Violations
No New Or Fixed Issues Found |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11482443 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482443 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482444 | Triggered | Username Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482444 | Triggered | Username Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482445 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482445 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482446 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482446 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482448 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482448 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482449 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482449 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482450 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
| 11482450 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482451 | Triggered | Generic Password | 4ac7ddd | test/integration/data/python-vul-file.py | View secret |
| 11482451 | Triggered | Generic Password | 4ac7ddd | internal/commands/data/python-vul-file.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…nctionality' into feature/benalvo/vorapl-engine-functionality
tamarleviCm
reviewed
Jun 20, 2024
| } | ||
|
|
||
| err, _ := executeCommand(t, args...) | ||
| assert.NilError(t, err, "Sending empty source file should not fail") |
There was a problem hiding this comment.
Don't you return an error? if so - check the response
tamarleviCm
reviewed
Jun 20, 2024
| vorpalWrapper := grpcs.NewVorpalGrpcWrapper(viper.GetInt(commonParams.VorpalPortKey)) | ||
| if healthCheckErr := vorpalWrapper.HealthCheck(); healthCheckErr != nil { | ||
| fmt.Println("Health check failed with error: ", healthCheckErr) | ||
| t.Failed() |
There was a problem hiding this comment.
Suggested change
| t.Failed() | |
| assert.Assert(t, true, "log") | |
tamarleviCm
reviewed
Jun 20, 2024
| asserts.NotNil(t, err) | ||
| } | ||
|
|
||
| func TestExecuteVorpalScan_EngineNotRunningWithLicense_Success(t *testing.T) { |
There was a problem hiding this comment.
can you have a license for our tenant, and change it to happy flow?
…l-engine-functionality # Conflicts: # internal/wrappers/jwt-helper.go # internal/wrappers/mock/jwt-helper-mock.go
tamarleviCm
approved these changes
Jun 24, 2024
| } | ||
|
|
||
| func TestExecuteVorpalScan_InitializeAndRunUpdateVersion_Success(t *testing.T) { | ||
| configuration.LoadConfiguration() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist