Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose different status codes depending on scanning results #2400

Closed
ruigomescx opened this issue Mar 22, 2021 · 2 comments · Fixed by #2674 or #2726
Closed

Expose different status codes depending on scanning results #2400

ruigomescx opened this issue Mar 22, 2021 · 2 comments · Fixed by #2674 or #2726
Assignees
@joaoReigota1 @felipe-avelar
Labels
feature New feature
Milestone
Integrations (CI/CD)

Comments

@ruigomescx
Copy link
Collaborator

Description

Currently KICS when scanning only reports exit status code 0 when the scan has occurred successfully. This exit status code is linked with the current program execution and not the reporting of results/vulnerabilities.

We should give status code depending on whether results were found or not, and even depending on the severity of results found.
Also, we should output specific status code for when KICS doesn't run successfully (queries didn't load, program aborted earlier, etc.)

First, the a list of status code should be presented, before implementing them.
@ruigomescx ruigomescx added the feature New feature label Mar 22, 2021
@ruigomescx ruigomescx added this to the Integrations (CI/CD) milestone Mar 22, 2021
@joaoReigota1 joaoReigota1 self-assigned this Mar 31, 2021
@joaoReigota1 joaoReigota1 mentioned this issue Apr 1, 2021
Merged
@rogeriopeixotocx
Copy link
Contributor

Reopened as draft in #2726

@rogeriopeixotocx
Copy link
Contributor

@kaplanlior @markmishaevcx @nunoocx @ruigomescx

We should discuss here the requirements for this feature.

@kaplanlior kaplanlior mentioned this issue Apr 7, 2021
Merged
@rogeriopeixotocx rogeriopeixotocx mentioned this issue Apr 22, 2021
Closed
@rogeriopeixotocx rogeriopeixotocx linked a pull request Apr 22, 2021 that will close this issue
feat(engine): semantic exit code based on results (#2400) (#1721) #2726
Merged
rogeriopeixotocx pushed a commit that referenced this issue Apr 26, 2021
@joaoReigota1 @felipe-avelar
feat(engine): semantic exit code based on results (#2400) (#1721) (#2726
1463a4a 
)

Signed-off-by: Felipe Avelar <[email protected]>
Co-authored-by: Felipe Avelar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaoReigota1 joaoReigota1

@felipe-avelar felipe-avelar

Labels
feature New feature
Projects
None yet
Milestone
Integrations (CI/CD)
4 participants
@ruigomescx @joaoReigota1 @rogeriopeixotocx @felipe-avelar