Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets query should flag secrets in URL's #2785

Closed
rogeriopeixotocx opened this issue Apr 12, 2021 · 0 comments · Fixed by #3459
Closed

Secrets query should flag secrets in URL's #2785

rogeriopeixotocx opened this issue Apr 12, 2021 · 0 comments · Fixed by #3459
Labels
enhancement Enhancement feature New feature
Milestone
Queries Support

Comments

@rogeriopeixotocx
Copy link
Contributor

Description

We should be able to detect secrets into URL's like for example the tokens in a Slack Webhook

We can use these Regular expressions to further improve our secrets queries: https://github.com/zricethezav/gitleaks/blob/master/config/default.go
@rogeriopeixotocx rogeriopeixotocx added enhancement Enhancement feature New feature labels Apr 12, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Queries Support milestone Apr 12, 2021
@rogeriopeixotocx rogeriopeixotocx changed the title Secrets query should flag secrets like Slack's webhooks Secrets query should flag secrets in URL's Apr 12, 2021
joaoReigota1 added a commit that referenced this issue May 27, 2021
@joaoReigota1
Added Passwords And Secrets In URL common query #2785
bf83090 
Signed-off-by: João Reigota <[email protected]>
@joaoReigota1 joaoReigota1 mentioned this issue May 27, 2021
Merged
rogeriopeixotocx pushed a commit that referenced this issue May 28, 2021
@joaoReigota1
feat(query): Added Passwords And Secrets In URL common query #2785 (#…
cf7fc9d 
…3459)

Signed-off-by: João Reigota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement feature New feature
Projects
None yet
Milestone
Queries Support
Development

Successfully merging a pull request may close this issue.

feat(query): Added Passwords And Secrets In URL common query #2785 Checkmarx/kics
1 participant
@rogeriopeixotocx