Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinct results are computing the same similarity ID for query 'Using Default Namespace' #3796

Closed
rogeriopeixotocx opened this issue Jun 30, 2021 · 1 comment · Fixed by #3828
Closed

Distinct results are computing the same similarity ID for query 'Using Default Namespace' #3796

rogeriopeixotocx opened this issue Jun 30, 2021 · 1 comment · Fixed by #3828
Assignees
@felipe-avelar
Labels
bug Something isn't working kubernetes Kubernetes query query New query feature
Milestone
Core Engineering

Comments

@rogeriopeixotocx
Copy link
Contributor

Expected Behavior

Different results should have unique similarity ID

Actual Behavior

The same similarity ID is being computed for distinct results for the query 'Using Default Namespace'

image

Steps to Reproduce the Problem

  1. Run KICS scan against this sample https://codeberg.org/hjacobs/kube-web-view/src/branch/main/tests/e2e/deployment.yaml
  2. Check for duplicate results in the files listed under the query 'Using Default Namespace'

Specifications

  • Version: 1.3.4
  • Platform: Kubernetes
@rogeriopeixotocx rogeriopeixotocx added bug Something isn't working query New query feature kubernetes Kubernetes query labels Jun 30, 2021
@rogeriopeixotocx
Copy link
Contributor Author

We should consider using a combination of metadata.name and kind in this particular searchkey.

@rogeriopeixotocx rogeriopeixotocx changed the title Different results generate the same similarity ID for query 'Using Default Namespace' Distinct results are computing the same similarity ID for query 'Using Default Namespace' Jun 30, 2021
@felipe-avelar felipe-avelar self-assigned this Jul 2, 2021
@felipe-avelar felipe-avelar added this to the Core Engineering milestone Jul 2, 2021
@felipe-avelar felipe-avelar mentioned this issue Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipe-avelar felipe-avelar

Labels
bug Something isn't working kubernetes Kubernetes query query New query feature
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging a pull request may close this issue.

fix(query): changed search key from Using Default Namespace query to be more accurate Checkmarx/kics
2 participants
@rogeriopeixotocx @felipe-avelar