Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): changed search key from Using Default Namespace query to be more accurate #3828

Merged
merged 2 commits into from
Jul 9, 2021
Merged

fix(query): changed search key from Using Default Namespace query to be more accurate #3828

merged 2 commits into from
Jul 9, 2021

Conversation

felipe-avelar
Copy link
Contributor

Signed-off-by: Felipe Avelar [email protected]

Closes #3796

Proposed Changes

  • Updated query searchKey to also check kind and be more accurate when pointing out a result

I submit this contribution under the Apache-2.0 license.

@felipe-avelar felipe-avelar added query New query feature kubernetes Kubernetes query accuracy Query accuracy (FN and FP) labels Jul 7, 2021
@felipe-avelar felipe-avelar added this to the Query Accuracy milestone Jul 7, 2021
@felipe-avelar felipe-avelar self-assigned this Jul 7, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Jul 7, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Jul 7, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

@felipe-avelar
Corrected query tests
ed751ba 
Signed-off-by: Felipe Avelar <[email protected]>
rogeriopeixotocx
rogeriopeixotocx approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 2e0ba3b into master Jul 9, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the bugfix/doubled-similarity-id branch July 9, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@joaoReigota1 joaoReigota1 Awaiting requested review from joaoReigota1

Assignees

@felipe-avelar felipe-avelar

Labels
accuracy Query accuracy (FN and FP) kubernetes Kubernetes query query New query feature
Projects
None yet
Milestone
Query Accuracy
Development

Successfully merging this pull request may close these issues.

Distinct results are computing the same similarity ID for query 'Using Default Namespace'
3 participants
@felipe-avelar @kicsbot @rogeriopeixotocx