Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs with tracker counters #2767

Merged
merged 7 commits into from
Apr 14, 2021
Merged

Fix bugs with tracker counters #2767

merged 7 commits into from
Apr 14, 2021

Conversation

joaoReigota1
Copy link
Collaborator

@joaoReigota1 joaoReigota1 commented Apr 9, 2021 •
edited
Loading

Closes #2735

Proposed Changes

  • Fixed Bug where tracker counters weren't correct
  • Fixed Issue where subcharts in helm would be re-rendered
  • Resolved files under general resolver are now added to the excluded files
  • Added new function to FileSystemSourceProvider to add new excluded files
  • Added/Improved Unit tests for pkg/engine/provider
  • Refactored helm part of get sources

I submit this contribution under Apache-2.0 license.

@joaoReigota1 joaoReigota1 added bug Something isn't working enhancement Enhancement go Pull requests that update Go code labels Apr 9, 2021
@joaoReigota1 joaoReigota1 added this to the Core Engineering milestone Apr 9, 2021
@joaoReigota1 joaoReigota1 self-assigned this Apr 9, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Apr 12, 2021

Scan submitted to Checkmarx

@joaoReigota1 joaoReigota1 marked this pull request as ready for review April 12, 2021 11:26
@kicsbot
Copy link
Contributor

kicsbot commented Apr 12, 2021 •
edited
Loading

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

felipe-avelar
felipe-avelar previously requested changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments

pkg/engine/provider/filesystem.go Outdated Show resolved Hide resolved
pkg/engine/provider/provider.go Outdated Show resolved Hide resolved
rogeriopeixotocx
rogeriopeixotocx suggested changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides removing the private function from the interface I believe it looks good

pkg/engine/provider/provider.go Outdated Show resolved Hide resolved
rogeriopeixotocx
rogeriopeixotocx approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 17ec26a into master Apr 14, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_bugs_with_tracker_counters branch April 14, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@joaoReigota1 joaoReigota1

Labels
bug Something isn't working enhancement Enhancement go Pull requests that update Go code
Projects
None yet
Milestone
Core Engineering
Development

Successfully merging this pull request may close these issues.

Incorrect Files scanned and Parsed files counters for Helm and Docker
4 participants
@joaoReigota1 @kicsbot @rogeriopeixotocx @felipe-avelar