Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve GoReport card issues Closes #2298 #2777

Merged
merged 2 commits into from
Apr 12, 2021

Conversation

rafaela-soares
Copy link
Contributor

Closes #2298

Proposed Changes

  • Solving ineffassign issues
  • Solving golint issues

I submit this contribution under Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Apr 12, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Apr 12, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 1 vulnerabilities
High 0 High
Medium 0 Medium
Low 1 Low
Info 0 Info

Violation Summary

No policy violation found

@rafaela-soares rafaela-soares added feature New feature good first issue Community: beginner-friendly issues labels Apr 12, 2021
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit fe55ac7 into master Apr 12, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/solving_go_report_card_issues branch April 12, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature good first issue Community: beginner-friendly issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solve GoReport card issues
4 participants