Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics) print CPU and Memory usage in logs (#2379) #2961

Merged
merged 16 commits into from
Apr 26, 2021
Merged

feat(analytics) print CPU and Memory usage in logs (#2379) #2961

merged 16 commits into from
Apr 26, 2021

Conversation

joaoReigota1
Copy link
Collaborator

@joaoReigota1 joaoReigota1 commented Apr 22, 2021 •
edited
Loading

Signed-off-by: João Reigota [email protected]

Closes #2379

Proposed Changes

  • Added CPU and Memory usage to logs
  • Added hidden flag metrics with possible values of 'cpu', 'mem'

Added metrics to: get_queries, get_files, inspect, generate_report

MEM:

image

image

CPU:

image

image

I submit this contribution under Apache-2.0 license.

@joaoReigota1 joaoReigota1 added feature New feature go Pull requests that update Go code labels Apr 22, 2021
@joaoReigota1 joaoReigota1 added this to the Quality milestone Apr 22, 2021
@joaoReigota1 joaoReigota1 self-assigned this Apr 22, 2021
rogeriopeixotocx
rogeriopeixotocx suggested changes Apr 23, 2021
View reviewed changes
internal/metrics/metrics.go Outdated Show resolved Hide resolved
@rogeriopeixotocx rogeriopeixotocx changed the title Added CPU and Memory usage to logs #2379 feat(analytics) print CPU and Memory usage in logs (#2379) Apr 23, 2021
@rogeriopeixotocx rogeriopeixotocx mentioned this pull request Apr 24, 2021
Merged
rogeriopeixotocx
rogeriopeixotocx suggested changes Apr 24, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just a few comments

internal/console/kics.go Outdated Show resolved Hide resolved
internal/console/kics.go Outdated Show resolved Hide resolved
internal/console/kics.go Outdated Show resolved Hide resolved
internal/metrics/cpu_metric.go Show resolved Hide resolved
internal/metrics/mem_metric.go Show resolved Hide resolved
internal/metrics/metrics.go Show resolved Hide resolved
internal/metrics/metrics.go Outdated Show resolved Hide resolved
felipe-avelar
felipe-avelar suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check comments

docs/performance.md Outdated Show resolved Hide resolved
docs/performance.md Outdated Show resolved Hide resolved
internal/global/global.go Outdated Show resolved Hide resolved
internal/metrics/metrics.go Outdated Show resolved Hide resolved
felipe-avelar
felipe-avelar previously approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 478159e into master Apr 26, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/add_metrics branch April 26, 2021 23:18
@rogeriopeixotocx rogeriopeixotocx mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

@felipe-avelar felipe-avelar Awaiting requested review from felipe-avelar

Assignees

@joaoReigota1 joaoReigota1

Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Milestone
Quality
Development

Successfully merging this pull request may close these issues.

Add CPU and Memory usage to logs
3 participants
@joaoReigota1 @rogeriopeixotocx @felipe-avelar