Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): unwanted json log when using unknown flag/command (#2967) #2983

Merged
merged 5 commits into from
Apr 26, 2021

Conversation

felipe-avelar
Copy link
Contributor

Signed-off-by: Felipe Avelar [email protected]

Closes #2967

Proposed Changes

  • Removed log from unknown flag or command, since it happens before logger is set

I submit this contribution under Apache-2.0 license.

@felipe-avelar felipe-avelar added the bug Something isn't working label Apr 23, 2021
@felipe-avelar felipe-avelar added this to the CLI/UI milestone Apr 23, 2021
@felipe-avelar felipe-avelar self-assigned this Apr 23, 2021
@felipe-avelar felipe-avelar marked this pull request as draft April 23, 2021 15:56
@rogeriopeixotocx
Copy link
Contributor

looking good @felipe-avelar can you update the PR with some test evidence of the bug resolution?

@rogeriopeixotocx rogeriopeixotocx changed the title fix(log): fixed unwanted json log when using unknown flag or command fix(log): unwanted json log when using unknown flag/command (#2967) Apr 23, 2021
@felipe-avelar felipe-avelar marked this pull request as ready for review April 26, 2021 10:28
Signed-off-by: Felipe Avelar <[email protected]>
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the problem was fixed
image

I still get the bug running with an unknown flag

Signed-off-by: Felipe Avelar <[email protected]>
Copy link
Collaborator

@joaoReigota1 joaoReigota1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipe-avelar felipe-avelar merged commit 88a5703 into master Apr 26, 2021
@felipe-avelar felipe-avelar deleted the bugfix/json-unknow-flag branch April 26, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stringified json in error message
3 participants