Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): KICS does not execute scan as default anymore #3030

Merged
merged 5 commits into from
Apr 28, 2021

Conversation

felipe-avelar
Copy link
Contributor

@felipe-avelar felipe-avelar commented Apr 27, 2021

Signed-off-by: Felipe Avelar [email protected]

Closes #3029

Proposed Changes

  • Kics does not execute scan as default anymore
  • Removing deprecation warning

I submit this contribution under the Apache-2.0 license.

@@ -90,6 +90,13 @@ func TestConsole_Execute(t *testing.T) { //nolint
wantErr: false,
remove: "",
},
{
name: "test_kics_fail_without_scan",
args: []string{"kics", "--path", filepath.FromSlash("../../test/fixtures/tc-sim01/positive1.tf"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Signed-off-by: Felipe Avelar <[email protected]>
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit bae6ea5 into master Apr 28, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/remove-kics-scan branch April 28, 2021 09:21
@milesflo
Copy link

milesflo commented Apr 28, 2021

Please accept this PR to get this change pushed into the runner as soon as possible. Checkmarx/kics-github-action#12

@felipe-avelar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KICS does not execute scan as default
3 participants